Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prevent_user_existence_errors to cognito user pool client. #11604

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Add prevent_user_existence_errors to cognito user pool client. #11604

merged 7 commits into from
Mar 17, 2020

Conversation

claydanford
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #11340

Release note for CHANGELOG:

resource/aws_cognito_user_pool_client: Add `prevent_user_existence_errors` attribute.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSCognitoUserPoolClient'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSCognitoUserPoolClient -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSCognitoUserPoolClient_basic
=== PAUSE TestAccAWSCognitoUserPoolClient_basic
=== RUN   TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
=== PAUSE TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
=== RUN   TestAccAWSCognitoUserPoolClient_Name
=== PAUSE TestAccAWSCognitoUserPoolClient_Name
=== RUN   TestAccAWSCognitoUserPoolClient_allFields
=== PAUSE TestAccAWSCognitoUserPoolClient_allFields
=== RUN   TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== PAUSE TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== CONT  TestAccAWSCognitoUserPoolClient_basic
=== CONT  TestAccAWSCognitoUserPoolClient_allFields
=== CONT  TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField
=== CONT  TestAccAWSCognitoUserPoolClient_Name
=== CONT  TestAccAWSCognitoUserPoolClient_RefreshTokenValidity
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (19.29s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (19.34s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (30.54s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (30.73s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (30.92s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	31.778s
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap	0.026s [no tests to run]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws/internal/keyvaluetags	0.065s [no tests to run]
...

@claydanford claydanford requested a review from a team January 15, 2020 05:53
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/cognito tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 15, 2020
@claydanford claydanford mentioned this pull request Jan 15, 2020
Closed
@realanmup
Copy link

PreventUserExistenceErrors has been now enabled by default. This might work as update to old Cognito clients.

@kdrapala
Copy link

@realanmup no it's not. Actually when i apply a terraform cognito then this option is setted to "Legacy"

@alkis-hexa
Copy link

I agree with @KacperDrapala it still goes on the Legacy option, so a fix is still required on this

@realanmup
Copy link

Exactly, for the old cognito client, the option should be manually enabled. This PR is as expected.
Thanks.

@claydanford
Copy link
Contributor Author

@bflad, mind if we get a review of this small change?

Kindly,

CRD

@bacoboy
Copy link

bacoboy commented Feb 10, 2020

Coming up on a month on this PR -- how do we push this across the finish line?

@claydanford
Copy link
Contributor Author

claydanford commented Feb 14, 2020 •
edited
Loading

Coming up on a month on this PR -- how do we push this across the finish line?

This needs some attention from someone who can review. I have suggested several people when adding a reviewer with no bites yet.

@Skyfallz
Copy link

Skyfallz commented Mar 6, 2020

@aeschright is it possible to get an update on this one please ? :) Thanks for your work.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 17, 2020
bflad
bflad suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @claydanford 👋 Thank you for submitting this. See the below feedback and then we can get this in. Please reach out with any questions or if you do not have time to implement these items. 👍

aws/resource_aws_cognito_user_pool_client.go Outdated Show resolved Hide resolved
aws/resource_aws_cognito_user_pool_client.go Outdated Show resolved Hide resolved
website/docs/r/cognito_user_pool_client.markdown Outdated Show resolved Hide resolved
@bflad bflad self-assigned this Mar 17, 2020
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 17, 2020
claydanford and others added 4 commits March 17, 2020 11:11
@claydanford @bflad
Update aws/resource_aws_cognito_user_pool_client.go
091961f 
Change default to computed.

Co-Authored-By: Brian Flad <bflad417@gmail.com>
@claydanford @bflad
Update aws/resource_aws_cognito_user_pool_client.go
11ef3fe 
Remove Elem field.

Co-Authored-By: Brian Flad <bflad417@gmail.com>
@claydanford @bflad
Update website/docs/r/cognito_user_pool_client.markdown
e31c84c 
Update documentation.

Co-Authored-By: Brian Flad <bflad417@gmail.com>
@claydanford
Merge branch 'master' into user-existence-errors
18440ac
@bflad bflad added this to the v2.54.0 milestone Mar 17, 2020
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Mar 17, 2020
@claydanford claydanford requested a review from bflad March 17, 2020 16:56
bflad
bflad approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you so much, @claydanford 🚀

Output from acceptance testing:

--- PASS: TestAccAWSCognitoUserPoolClient_disappears (8.86s)
--- PASS: TestAccAWSCognitoUserPoolClient_basic (9.71s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFields (10.04s)
--- PASS: TestAccAWSCognitoUserPoolClient_Name (14.09s)
--- PASS: TestAccAWSCognitoUserPoolClient_allFieldsUpdatingOneField (14.44s)
--- PASS: TestAccAWSCognitoUserPoolClient_RefreshTokenValidity (14.81s)
--- PASS: TestAccAWSCognitoUserPoolClient_analyticsConfig (30.07s)

@bflad bflad merged commit 39333bc into hashicorp:master Mar 17, 2020
bflad added a commit that referenced this pull request Mar 17, 2020
@bflad
Update CHANGELOG for #11604
2475992
@ghost
Copy link

ghost commented Mar 19, 2020

This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.54.0
Development

Successfully merging this pull request may close these issues.

Cognito feature to enable PreventUserExistenceErrors for user pool clients.
7 participants
@claydanford @realanmup @kdrapala @alkis-hexa @bacoboy @Skyfallz @bflad